Codecov Report

Merging #584 (b119d48) into main (84f0194) will decrease coverage by 1.32%.
The diff coverage is 7.57%.

@@            Coverage Diff             @@
##             main     #584      +/-   ##
==========================================
- Coverage   19.81%   18.49%   -1.33%     
==========================================
  Files         210      219       +9     
  Lines       27884    30146    +2262     
==========================================
+ Hits         5525     5575      +50     
- Misses      21333    23544    +2211     
- Partials     1026     1027       +1     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84f0194...b119d48. Read the comment docs.

Should we move this authority metadata system to the bank module itself? @ValarDragon wdyt?

I think mint/burn permissions for a token do generally need to be rethought much more, and get into bank natively. I'm not fully sure how to square different approaches to this. This approach feels too restrictive for many general tokens (e.g. osmo, where we want many different modules to get mint perms -- Superfluid is in this set).

I was suggesting this approach as a non-state breaking approach to add more protections cosmos/cosmos-sdk#10386 . I think something cool would be to get this module to emit a "FactoryMintRestrictions" and "FactoryBurnRestrictions" functions, that we then compose into that approach. (Rather than need this authorization lists in bank itself. I actually like that this module is specifying its own permissioning schema!)

(We should also use that approach to restrict factory module perms)

The status of that is its in a PR thats imo good to merge pending spec update. (cosmos/cosmos-sdk#10771). Unclear what SDK team's thoughts on it are though. I think we should go ahead and just use that even if the SDK doesn't want to. (It solves having to worry about gamm module minting non-LP shares for instance, and is imo critical for superfluid)

I really like how this approach doesn't require the use of a contract per token, which is a broken pattern.

Rebased this to main, as well as

1. Removed ForceTransfers
2. Only allowed Mint and Burns to/from the admin address

Closing because has been replaced by other PRs